Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unescaped # in SVG data URLs #20962

Merged
merged 2 commits into from
Oct 25, 2016
Merged

Fix unescaped # in SVG data URLs #20962

merged 2 commits into from
Oct 25, 2016

Conversation

patrickhlauke
Copy link
Member

Uses a custom string replacement function to ensure that # characters are correctly URL encoded to %23, to avoid Firefox/IE11 choking on the SVG data URLs.

Closes #20956

@patrickhlauke
Copy link
Member Author

@mdo / @cvrebert would appreciate thoughts/review (because of the custom Sass function I had to add)

@jonathanhefner
Copy link
Contributor

Would an easier approach be a SASS function that only escapes hex colors? Such a function would only check the first string character, and would only be applied to the color, instead of the entire URL.

@patrickhlauke
Copy link
Member Author

@mdo @cvrebert as we're getting various duplicate issues filed now, I'm going ahead with merging this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants