Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #17201: Use Tether as a non-window global variable #20744

Closed
wants to merge 2 commits into from
Closed

Refs #17201: Use Tether as a non-window global variable #20744

wants to merge 2 commits into from

Conversation

karolyi
Copy link

@karolyi karolyi commented Sep 18, 2016

No description provided.

@cvrebert
Copy link
Collaborator

Unless I'm mistaken, this won't work. The browser will throw ReferenceError: Tether is not defined.

@karolyi
Copy link
Author

karolyi commented Sep 18, 2016

See #18647 (comment)

@karolyi
Copy link
Author

karolyi commented Sep 18, 2016

or to be on the actually creative side, I can update the pull request with tooltip being invoked with jQuery and Tether, and then do an if (Tether === undefined && window.Tether === undefined) ...

@cvrebert
Copy link
Collaborator

Tether === undefined will throw a ReferenceError exception in the non-webpack case if Tether is unavailable.

@cvrebert
Copy link
Collaborator

Properly fixing this for all the dependencies (i.e. #17201) seems like a better use of our time.
Thanks though.

@cvrebert cvrebert closed this Sep 18, 2016
@karolyi
Copy link
Author

karolyi commented Sep 18, 2016

@cvrebert see my last commit, that is a temporary fix, until you get the es6 imports right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants