v4: Fix card columns #20665
Merged
v4: Fix card columns #20665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cards must be inline-block in columns, otherwise they can get split across columns
|
FYI, looks like #20664 is the same fix as this, minus the helper text. One should probably be closed out. |
|
I already added display:inline-block.
|
|
Card columns are buggy as hell, and you've commented on nearly three year old issue. If you need rock solid layout here, we recommend our grid system, Masonry, or another manual approach. Sorry, we had much higher hopes for card columns, but the CSS support across browsers just isn't there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20654 by reverting #20447. Cards must be
inline-blockin columns, otherwise they can get split across columns.