update click state when hiding so can be shown again by trigger #20463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bardiharborow
previously approved these changes
Dec 23, 2016
bardiharborow
dismissed
their stale review
Actually, we need to be setting all members of this._activeTrigger to false.
|
opened #21440 as an easier way to resolve conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16732 by applying @markbao's suggestion when the tooltip is hidden. addresses issue demonstrated here https://jsbin.com/bapohu/edit?html,js,output. I couldn't reproduce the other 2 scenarios with v4 outlined in #16732