Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: close menu when focusing outside element #19978

Closed
wants to merge 5 commits into from

Conversation

pvdlg
Copy link
Contributor

@pvdlg pvdlg commented May 28, 2016

Currently the behavior of dropdown menu is inconsistent for mouse and keyboard users:

  • when menu is open, clicking outside, close it
  • when menu is open, focusing outside (tab key), doesn't close it

The changes in this PR close the dropdown menu when focusing on an element outside the dropdown menu.
It's handled in a similar fashion it's currently done for click events (except that focusin events inside the menu don't close it contrary to click events).

@twbs-rorschach
Copy link

Hi @vanduynslagerp!

Thanks for wanting to contribute to Bootstrap by sending this pull request!
Unfortunately, your pull request seems to have some problems:

You'll need to fix these mistakes and revise your pull request before we can proceed further.
Once you've fixed these problems, you can either ask the maintainers to re-open this pull request, or you can create a new pull request.
Thanks!

(Please note that this is a fully automated comment.)

@pvdlg pvdlg deleted the dropdown-close-focusout branch January 4, 2017 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants