Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variables for controlling button active/hover darken amount #19414

Conversation

kevinkucharczyk
Copy link
Contributor

fixes #19353

background-color: darken($color, 17%);
border-color: darken($color, 25%);
background-color: darken($color, $btn-active-hover-bg-darken);
border-color: darken($color, $btn-active-hover-border-darken);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 6 spaces, but was indented 10 spaces

@sqal
Copy link
Contributor

sqal commented Apr 16, 2016

👍 or maybe just allow user to take full control of the bg color, border-color, and text color for hover state? and not just the amount of darken ? I personally always needed this kinda control of the buttons, like since BS 3. Anyway.. I hope this PR will land in alpha v3 :).

@ghost
Copy link

ghost commented Sep 27, 2016

I personally need buttons which are lightened on hover, not darkened. Why not to give full control of button hover, focus and active states through variables? Like
background-color:: $btn-hover-bg;
border-color :$btn-hover-border;
etc.

@mdo
Copy link
Member

mdo commented Oct 28, 2016

Closing per @sqal's comment. This is the second or third PR I've seen deal with this. Opening a new issue to track and see what'd be more doable/helpful. Thanks though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants