Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal: Respect $enable-rounded setting #18844

Merged
merged 1 commit into from
Jan 11, 2016
Merged

Modal: Respect $enable-rounded setting #18844

merged 1 commit into from
Jan 11, 2016
+1 −1

Conversation

AndersSahlin
Copy link
Contributor

See issue: #18385

I think this issue is still present, somewhat.
.modal-content has rounded borders even if they have been disabled with the setting. Probably because it uses $border-radius-lg instead of the mixin.
https://github.com/twbs/bootstrap/blob/v4-dev/scss/_modal.scss#L52

@AndersSahlin AndersSahlin changed the title Modals respect $enable-rounded setting Modal: Respect $enable-rounded setting Jan 11, 2016
@cvrebert cvrebert added this to the v4.0.0-alpha.3 milestone Jan 11, 2016
cvrebert added a commit that referenced this pull request Jan 11, 2016
@cvrebert
Merge pull request #18844 from AndersSahlin/patch-1
4fae7cb 
Modal: Respect $enable-rounded setting
[skip sauce]
@cvrebert cvrebert merged commit 4fae7cb into twbs:v4-dev Jan 11, 2016
@cvrebert
Copy link
Collaborator

Thanks!

@cvrebert cvrebert mentioned this pull request Jan 11, 2016
Merged
@AndersSahlin AndersSahlin deleted the patch-1 branch January 15, 2016 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
css v4
Projects
None yet
Milestone
v4.0.0-alpha.3
Development

Successfully merging this pull request may close these issues.
2 participants
@AndersSahlin @cvrebert