Modal is cut off when viewpoint is between sm breakpoint and modal-md variables. #18443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d value. When resizing the modal between the sm default breakpoint of 544px and the modal-md value of 600px, the modal gets cut off until it reaches the 600px width. The fix applied here was to use max-width instead of width.
|
Or perhaps we should adjust |
|
Ah, right you are. I added the same max-width fix to modal-sm and modal-lg. If possible, I'd rather that modal-md not be any smaller than it currently is. |
Merged
|
Superseded by #21207. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix modal being cut off when caught between sm breakpoint and modal-md value.
When resizing the modal between the sm default breakpoint of 544px and the modal-md value of 600px, the modal gets cut off until it reaches the 600px width. The fix applied here was to use max-width instead of width.