Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #17265 - Make sure that global module names are capitalized in #18313

Closed
wants to merge 1 commit into from

Conversation

skrivle
Copy link

@skrivle skrivle commented Nov 22, 2015

Fixes #17265

@twbs-rorschach
Copy link

Hi @vejersele!

Thanks for wanting to contribute to Bootstrap by sending this pull request!
Unfortunately, your pull request seems to have some problems:

You'll need to fix these mistakes and revise your pull request before we can proceed further.
Once you've fixed these problems, you can either ask the maintainers to re-open this pull request, or you can create a new pull request.
Thanks!

(Please note that this is a fully automated comment.)

@skrivle
Copy link
Author

skrivle commented Nov 22, 2015

Hmm can someone reopen this pull request? I made changes to the grunt file in order to fix the generated output. No changes to the source files are needed in this case ... Thanks!

cc: @fat @cvrebert

@cvrebert
Copy link
Collaborator

@vejersele Please exclude /dist/js files from the pull request. Thanks.

@skrivle skrivle force-pushed the bugfix/babelModuleNames branch from 9768629 to 77a8b44 Compare November 22, 2015 19:30
@cvrebert cvrebert added this to the v4.0.0-alpha.2 milestone Nov 24, 2015
@skrivle
Copy link
Author

skrivle commented Nov 25, 2015

Any idea why the build failed? Seems like a configuration issue on the server ...

@cvrebert
Copy link
Collaborator

@vejersele rvm/rvm#3559

@AStoker
Copy link

AStoker commented Feb 24, 2016

Updates to this?

@mdo mdo modified the milestones: v4.0.0-alpha.3, v4.0.0-alpha.4 May 8, 2016
@mdo mdo modified the milestones: v4.0.0-alpha.5, v4.0.0-alpha.6 Oct 19, 2016
@mdo mdo removed this from the v4.0.0-alpha.6 milestone Nov 26, 2016
@mdo
Copy link
Member

mdo commented Nov 26, 2016

Closing per #17265. Thanks though!

@mdo mdo closed this Nov 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants