Use Tether's addTargetClasses option instead of manually removing classnames #17094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\cc @fat |
Thanks so much for maintaining Tether! Our hand-rolled positioning logic was getting pretty hairy and yet still wasn't bug-free; we were quite glad to be able to nuke it in favor of Tether. |
|
oh this is fire |
|
@lincolndbryant sorry took so long to get this in - thanks for the help! |
|
😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Tether 0.7.1 (May 2015) - we introduced
addTargetClasses, which prevents adding any classnames to the target el whenfalse. I confirmed this with the visual tests, but can add a unit test if helpful.I found the issue referenced in the comment and will resolve, sorry that got lost.
Thanks so much for incorporating Tether!