-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyboard
option to carousel
#14590
Conversation
@cvrebert Docs wording LGTY? |
be76960
to
efb13de
Compare
👍 |
/to @fat |
Also adds unit tests for keyboard events. Fixes #14468.
efb13de
to
038a63b
Compare
I like to think of the plugins like an ecosystem – and if we add this option in one place, we should add it to all the plugins… That said, I'm not really crazy about adding this keyboard option. Seems like a bit of a weird use case – and something that could be solved in other ways. |
If i'm missing some other perspective though, let me know :) - the code looks really good, and swooned at the unit tests |
I agree that the specific use case mentioned in #14468 is weird but I feel that this is a small change that helps out somebody which is entirely relying on the data-api. Besides that we have a |
oh yeah… hrm… it does still really feel wrong to have an option that is essentially fuck accessibility, but your call. can't remember the exat details of the modal keyboard option, but i think i was also not super excited about it |
merged it… i think we should audit in 4 and see if we can't have a more graceful way of turning these types of things off across plugins tho |
Also adds unit tests for keyboard events.
Fixes #14468.