Remove .modal-open class after backdrop is hidden

[hnrch02]

Fixes #14274 and #14632.

[cvrebert]

Not quite optimal for modals with overflowing content as is demonstrated in the second modal.

Could you elaborate?

[hnrch02]

Sure, give me a second, I'll post a screencap.

[hnrch02]

Notice how the scrollbar fades to the original one in the first tab (new behavior) and immediately changes back to the body scrollbar in the second one (current behavior).

[X-Coder]

The fix is not complete. You should also think of cases when multiple instances are opened at the same time: only when the last dialog is closed, it should remove the .modal-open class.

For example I use this for forms inside modals, popping up another modal when error occurs.

[hnrch02]

We do not support overlapping modals and state this explicitly in the docs:

Overlapping modals not supported

Be sure not to open a modal while another is still visible. Showing more than one modal at a time requires custom code.

[X-Coder]

Yes I know you are currently not supporting it, thats why I need to write workarounds each time I need to use this. And I'm guessing I'm not the only one. I hoped for a future release you could support it, would make life easier.

[cvrebert]

Anyway, that issue is broader than just this pull request. We're unlikely to try to add such a feature before v4, and even then it's still quite uncertain.

[hnrch02]

Also, you might be interested in nakupanda/bootstrap3-dialog, which we have listed in the "Resources" section of the Expo.

[X-Coder]

Thank you hnrch02, nakupanda's bootstrap3-dialog is very good, I'm using it already for everything were I need dialogs, it's a lot easier to use than plain bootstrap.

Of course, it has the same scrollbar-shifting issues on "stacked" dialogs because it sits on top of bootstrap's modal (which doesn't support it - as you wrote). Debugging of it showed its related to .modal-open class, so I needed to write workarounds for both.