Update generated markup by the tooltip plugin in docs; fixes #13796 #13799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it'd be fair to omit the ID altogether in this case. |
|
Done, now what about my second point? |
|
That hasn't been documented. Not sure if it's necessary. |
|
AFAICT, we haven't documented the other accessibility improvements either, right? |
|
Travis build failed because npm is experiencing some problems right now, unrelated to anything I changed. |
cvrebert
added a commit
that referenced
this pull request
Jun 12, 2014
Update generated markup by the tooltip plugin in docs; fixes #13796
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about
id="tooltip[Random number]", any ideas @cvrebert? Would also need to mention that the triggering element getsaria-describedby.Also, has the ID assignment and
aria-describedbybusiness been documented already?