Add class which removes gutter between columns #13551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| .no-gutter | ||
| { | ||
| margin-left: 0 !important; |
There was a problem hiding this comment.
I don't think using !important is gonna fly.
There was a problem hiding this comment.
Yeah, you're right. It's unnecessary.
cvrebert
changed the title
added 3 commits
May 9, 2014 18:46
| // Remove gutter between columns in row | ||
|
|
||
| .no-gutter | ||
| { |
There was a problem hiding this comment.
Why is this brace on a new line?
|
We'll pass on adding this for now. |
|
@mdo Can you explain why are you passing this for now? Do you have any other plans about removing gutter, or you don't want it at all? |
|
This is just feature, new possibility. IMO quite useful. Some elements don't needs gutter, but should use grid system. Just new quite usefull idea. Some developers asking for solution to remove defult gutter for some elements. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds ".no-gutter" class for rows, which removes columns gutter. I've used attribute selector to omit enlarging of grid.