Only hide modal on transitionend if the event originates from the modal;... #13430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been thinking we should maybe just add a helper for this in the transition plugin. Because we need a similar thing for basically everywhere |
|
Yeah, seems to be the better option, what exactly were you thinking about? Something like this? |
|
Happy to help test any fixes you have. Like @fat says, it seems to be an issue in a few spots (one was already fixed with the collapse). |
|
yep… i think it could do the emulateTransitionEnd bit as well |
|
Maybe then we should merge this as a temporary solution for 3.2 until we find a better way to handle underlying problem. |
|
im ok with that |
fat
added a commit
that referenced
this pull request
Jun 11, 2014
|
@hnrch02 i took a shot at implementing a special event – what do you think? |
|
We can definitely close this in favor of the PR and continue the discussion there. |
|
cool 👍 |
fat
added a commit
that referenced
this pull request
Jun 11, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... fixes #13223
Needs testing from @spotts-ce, as I myself cannot reproduce the problem he is encountering.
/cc @fat @cvrebert