Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #10433: Navbar z-index refactor #11188

Merged
merged 3 commits into from
Oct 21, 2013
Merged

Fixes #10433: Navbar z-index refactor #11188

merged 3 commits into from
Oct 21, 2013

Conversation

mdo
Copy link
Member

@mdo mdo commented Oct 21, 2013

Specifically:

  • Resets the default navbar z-index to auto at a certain breakpoint
  • Adds fixed navbar z-index var to fixed bottom navbar (previously only on fixed top navbar)

Something to test out though: does the default .navbar class need to have a z-index set at all? The only way this matters is for fixed navbars, which get their z-index. Perhaps we can remove the initial declaration?

* Resets the default navbar z-index to auto at a certain breakpoint
* Adds fixed navbar z-index var to fixed bottom navbar (previously only on fixed top navbar)
@mdo
Copy link
Member Author

mdo commented Oct 21, 2013

Came back and checked it out—doesn't look like we need that default z-index at all. Chucked the original auto override and also fixed up the default navbar example.

@mdo mdo mentioned this pull request Oct 21, 2013
mdo added a commit that referenced this pull request Oct 21, 2013
@mdo mdo merged commit 98378d2 into master Oct 21, 2013
@mdo mdo deleted the navbar_zindex_auto branch October 21, 2013 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant