Fix: @font-face path if importing bootstrap.less from another directory. #10941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| src: ~"url('@{icon-font-path}@{icon-font-name}.eot?iefix') format('embedded-opentype')", | ||
| ~"url('@{icon-font-path}@{icon-font-name}.woff') format('woff')", | ||
| ~"url('@{icon-font-path}@{icon-font-name}.ttf') format('truetype')", | ||
| ~"url('@{icon-font-path}@{icon-font-name}.svg#glyphicons-halflingsregular') format('swg')"; |
There was a problem hiding this comment.
I have no idea, how i made this typo. Thanks for noticing.
…-wip Conflicts: less/glyphicons.less
|
Travis build has failed because of some network timeout errors, weird. |
|
Fixed manually given conflicts and several commits here. Thanks! |
Closed
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Apr 11, 2014
…strap.less from another directory
|
I don't think that this fix is necessary. The less parser should be used with the |
ghost
mentioned this pull request
|
+1 @jhnns I would give a veto to the fix. can we re-open this issue? @mdo |
|
👍 |
sokra
added a commit
to sokra/bootstrap
that referenced
this pull request
May 8, 2014
Let the less compiler handle `url`s. See `--relative-urls` flag of `lessc`. This should result in correct behavior if bootstrap is `@import`ed from another less file.
Closed
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Nov 4, 2014
…strap.less from another directory
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Nov 4, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes @font-face path fix, if bootstrap.less is included from another directory.
For example:
Project.less file includes bootstrap.less from above directory, then @font-face path would be relative to bootstrap.less file itself not to project.less files.
This commit makes @font-face paths relative to actual project.less file.
Same issues is with v2.3.2, for which i have created pull request also.