Removing "strip for ie7" code from JavaScript #10858
Conversation
|
@dan-silver Could you enable Travis CI for your repo? |
|
Sure, I've added it. |
| @@ -106,7 +106,7 @@ | |||
|
|
|||
| if (!selector) { | |||
| selector = $this.attr('href') | |||
| selector = selector && /#/.test(selector) && selector.replace(/.*(?=#[^\s]*$)/, '') //strip for ie7 | |||
| selector = /#/.test(selector) && selector | |||
There was a problem hiding this comment.
I believe this line should just be eliminated entirely.
There was a problem hiding this comment.
When I removed this line, it fails the test "should test if element has a # before assuming it's a selector". Should I remove the test as well or leave both of them as is?
|
Could you rebase the commits? Help: https://help.github.com/articles/interactive-rebase |
|
i dont think we should do this… it completely breaks the declarative api for ie7 (and other browsers which return full urls in href's). Also it's such an easy thing to add and doesn't really hurt anything. No real benefit in removing it. |
|
I'm going to close this for now. As long as we have |
|
Sounds like a fair enough v4 thing <3. |
|
So, save it for v4! :D 2013/12/27 Mark Otto [email protected]
Zlatan Vasović - ZDroid |
I have removed all cases where selectors or targets are being "stripped for ie7" since ie7 is no longer supported.
This resolves #10441.