Removing margins from :first-child / :last-child navbar-form #10549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navbar forms are not properly left and right aligning when first or last children accordingly. This leads to submit buttons out of alignment with other navbar / header / footer elements, and all page content when navbars are fixed.
Making sure to include compiled bootstrap css and min.css for pull request
|
This is no longer necessary per #11530. |
|
cool so this will now sit flush for left aligned forms too? thanks for the update. |
|
@drewcovi Ah, good point—didn't look at the |
|
@drewcovi Looks like there are some more thing to work on: http://jsbin.com/odeSiSo/5/. I'll get on them later tonight perhaps, unless you want first dibs :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navbar Forms that are first or last children and pulled right or left currently have left and right margins.
.navbar-nav.navbar-left, and .navbar-nav.navbar-right currently strip this margin away and allow elements within to justify to the left or right.
This update allows buttons in navbar-forms to align with other header / footer elements and when fixed to the top or bottom, also align with the elements on the page.