Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double border with table-bordered within a panel #10484

Merged
merged 1 commit into from
Sep 5, 2013

Conversation

kevinoconnor7
Copy link
Contributor

There was a small styling issue if you decided you wanted a table with table-bordered in a panel. Because the panel provides a border around the left and right sides of the table, the table-bordered class added another one on top of that. This results in the border on the left and right sides of the table being double the size of the border.

This merge should resolve this.

@ravenscroft
Copy link

Did you have a panel-body? That should provide some padding/margin between the panel and the table.

http://jsfiddle.net/vQcWy/

Otherwise this could be a nice feature if you don't want the additional padding/margin. However, perhaps the gutter should be remove also in this case.

@kevinoconnor7
Copy link
Contributor Author

It does work as intended with a panel-body, however I didn't want the padding. Actually, the tables show in the panel docs aren't wrapped in the panel-body.

As for the second example that you gave, you shouldn't have the table wrapped in a div, this adds a top and bottom gutter, see my example here.

@mdo mdo merged commit ac24404 into twbs:master Sep 5, 2013
@ravenscroft
Copy link

Ok. I see that example in the docs now. I must have missed it before. Thanks

@mdo
Copy link
Member

mdo commented Sep 5, 2013

Btw, I merged this after making some tweaks. Thanks!

@mdo mdo mentioned this pull request Sep 5, 2013
@kevinoconnor7 kevinoconnor7 deleted the panel-table-bordered branch September 5, 2013 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants