Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note the change to the progress bar. #10298

Merged
merged 2 commits into from
Sep 1, 2013
Merged

Note the change to the progress bar. #10298

merged 2 commits into from
Sep 1, 2013

Conversation

jhr007
Copy link
Contributor

@jhr007 jhr007 commented Aug 30, 2013

In v3 the inner progress bar should have .progress-bar not .bar

jhr007 added 2 commits August 29, 2013 23:21
In v3 the inner progress bar should have .progress-bar not .bar
@jhr007
Copy link
Contributor Author

jhr007 commented Aug 30, 2013

Compare v3:
http://getbootstrap.com/components/#progress

<div class="progress progress-striped">
  <div class="progress-bar progress-bar-success" role="progressbar" aria-valuenow="40" aria-valuemin="0" aria-valuemax="100" style="width: 40%">
    <span class="sr-only">40% Complete (success)</span>
  </div>
</div>
<div class="progress progress-striped">
  <div class="progress-bar progress-bar-info" role="progressbar" aria-valuenow="20" aria-valuemin="0" aria-valuemax="100" style="width: 20%">
    <span class="sr-only">20% Complete</span>
  </div>
</div>
<div class="progress progress-striped">
  <div class="progress-bar progress-bar-warning" role="progressbar" aria-valuenow="60" aria-valuemin="0" aria-valuemax="100" style="width: 60%">
    <span class="sr-only">60% Complete (warning)</span>
  </div>
</div>
<div class="progress progress-striped">
  <div class="progress-bar progress-bar-danger" role="progressbar" aria-valuenow="80" aria-valuemin="0" aria-valuemax="100" style="width: 80%">
    <span class="sr-only">80% Complete (danger)</span>
  </div>
</div>

vs v2:
http://getbootstrap.com/2.3.2/components.html#progress

<div class="progress progress-info progress-striped">
    <div class="bar" style="width: 20%"></div>
</div>
<div class="progress progress-success progress-striped">
    <div class="bar" style="width: 40%"></div>
</div>
<div class="progress progress-warning progress-striped">
    <div class="bar" style="width: 60%"></div>
</div>
<div class="progress progress-danger progress-striped">
    <div class="bar" style="width: 80%"></div>
</div>

cvrebert added a commit that referenced this pull request Sep 1, 2013
Note the change to the progress bar.
@cvrebert cvrebert merged commit 2066ea5 into twbs:master Sep 1, 2013
@cvrebert
Copy link
Collaborator

cvrebert commented Sep 1, 2013

Thanks!

cvrebert added a commit that referenced this pull request Sep 1, 2013
@mdo mdo mentioned this pull request Sep 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants