Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 10212 - Make custom max-width on row conform to Bootstrap convention #10227

Merged
merged 2 commits into from
Sep 4, 2013

Conversation

UTCWebDev
Copy link
Contributor

Bootstrap break point for tablet portrait 768 keeps the row intact, so it's not appropriate to have off-canvas elements at that width. Custom off-canvas.css should be breakpoint 767px

#10212

Bootstrap break point for tablet portrait 768 keeps the row intact, so it's not appropriate to have off-canvas elements at that width. Custom off-canvas.css should be breakpoint 767px
@@ -14,7 +14,7 @@ footer {
* Off Canvas
* --------------------------------------------------
*/
@media screen and (max-width: 768px) {
@media screen and (max-width: 767px) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should conform to max-width convention of Bootstrap. row-fluid does not break at 768, it breaks at 767

html overflow-x must be hidden to prevent accidental x-scroll on small screens. This is more apparent with touch screens, where the user often gestures diagonally instead of a true vertical gesture.
@@ -2,6 +2,9 @@
* Style tweaks
* --------------------------------------------------
*/
html {
overflow-x: hidden;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

necessary to prevent unintentional x-scroll on small viewports

mdo added a commit that referenced this pull request Sep 4, 2013
Fixes 10212 - Make custom max-width on row conform to Bootstrap convention
@mdo mdo merged commit 88e1e20 into twbs:master Sep 4, 2013
mdo added a commit that referenced this pull request Sep 4, 2013
@mdo mdo mentioned this pull request Sep 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants