Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paramer order in .size() mixin #5596

Closed
dragunoff opened this issue Oct 22, 2012 · 2 comments
Closed

Paramer order in .size() mixin #5596

dragunoff opened this issue Oct 22, 2012 · 2 comments
Labels

Comments

@dragunoff
Copy link

The size mixin is a little confusing, because the x and y axises are swapped. In CSS properties that accept coordinates as input it's always x followed by y (background-size, background-position). That's why I think the .size mixin should accept width first and then height.

.size(@width, @height) {
  width: @width;
  height: @height;
}
@balmor
Copy link

balmor commented Oct 29, 2012

I agree with you, completely.

@mdo mdo closed this as completed in 34880e3 Nov 5, 2012
@mdo
Copy link
Member

mdo commented Nov 5, 2012

Will resolve in 3.0 since it maybe break compatibility for folks already using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants