Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New alert text #4909

Closed
leeaston opened this issue Sep 1, 2012 · 6 comments
Closed

New alert text #4909

leeaston opened this issue Sep 1, 2012 · 6 comments

Comments

@leeaston
Copy link

leeaston commented Sep 1, 2012

How about having three classes; alert-error-text, alert-success-text, alert-info-text, such that they change the colour of the text. The current alerts are good, but can sometimes be more than needed to get attention.

What do you think?

Cheers
Lee

@thezoggy
Copy link

thezoggy commented Sep 2, 2012

personally I think that people can just use their own css class stacked on top if they wanna stylize it.. there are already enough color classes as is..

@richardp-au
Copy link

I personally add the following to my code where necessary.

.text-warning {
  color: @warningText;
}
.text-error {
  color: @errorText;
}
.text-success {
  color: @successText;
}

(I don't have the info colour but I'd add it if I ever needed to.)

I don't think it'd be a bad idea to add these classes but it's equally easy to add them to my own code.

@mdo mdo closed this as completed in 9d5f9ec Sep 3, 2012
@richardp-au
Copy link

Cool. Thanks Mark.

@will-stone
Copy link

This is on the blog of 2.1.1 as included but I cannot seem to find it, and it appears to have dissappeared from the docs. Was I imagining things?

@leeaston
Copy link
Author

leeaston commented Sep 6, 2012

@will-stone
Copy link

Went to that page, scanned it and searched for "text-success" and it's not there. Also searched the CSS and it seems to have been removed.

svda pushed a commit to myxt/bootstrap that referenced this issue Oct 9, 2012
* 'master' of https://github.com/twitter/bootstrap: (102 commits)
  last rebuild before 2.1.1 release
  regrettably remove the animated button for download on homepage to improve page performance in some browsers
  fixes twbs#4968 manually: typo in scaffolding docs about offset classes
  improve comments in image styles
  fixes twbs#4958: add version to minified js
  fixes twbs#4885: correct use of skew in .skew() mixin for FF
  fixes twbs#4957: use input border var for select element instead of #ddd
  fixes twbs#4959: docs example
  fixes twbs#4935: properly comment responsive image techniques and add CSS tests to support
  fixes twbs#4146: IE7-8 responsive image helper
  add comment to go with updated box-shadow mixin
  fixes twbs#4909: add color utility classes .text-warning, etc and document them
  fixes twbs#4925: ensure docs examples don't use fixed font-size and line-height for .lead
  fixes twbs#4922: use basefontsize for realz on .lead
  fixes twbs#4902: proper accordion html example
  fixes twbs#4910: use @baseLineHeight * 1.5 for .lead font-size
  fixes twbs#4869: typo in getting started
  fixes twbs#4901: attribute typo and reran make
  fixes twbs#4896: reflect media query order in docs
  fixes twbs#4824: scope table grid sizes to .table instead of table
  ...
svda pushed a commit to myxt/bootstrap that referenced this issue Oct 9, 2012
* master: (102 commits)
  last rebuild before 2.1.1 release
  regrettably remove the animated button for download on homepage to improve page performance in some browsers
  fixes twbs#4968 manually: typo in scaffolding docs about offset classes
  improve comments in image styles
  fixes twbs#4958: add version to minified js
  fixes twbs#4885: correct use of skew in .skew() mixin for FF
  fixes twbs#4957: use input border var for select element instead of #ddd
  fixes twbs#4959: docs example
  fixes twbs#4935: properly comment responsive image techniques and add CSS tests to support
  fixes twbs#4146: IE7-8 responsive image helper
  add comment to go with updated box-shadow mixin
  fixes twbs#4909: add color utility classes .text-warning, etc and document them
  fixes twbs#4925: ensure docs examples don't use fixed font-size and line-height for .lead
  fixes twbs#4922: use basefontsize for realz on .lead
  fixes twbs#4902: proper accordion html example
  fixes twbs#4910: use @baseLineHeight * 1.5 for .lead font-size
  fixes twbs#4869: typo in getting started
  fixes twbs#4901: attribute typo and reran make
  fixes twbs#4896: reflect media query order in docs
  fixes twbs#4824: scope table grid sizes to .table instead of table
  ...
stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants