-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order of jQuery/popper file includes backwards #30873
Comments
The wording might be confusing but the examples are right: "it" at the end of the sentence refers to "our compiled JavaScript", not jQuery. Not sure about the best way to make this less confusing, though. |
Right, that's my point, the grammar/wording is misleading and should be changed. I'm not an English major but it seems like a dangling participle. If the above suggestion doesn't seem more clear, then how about:
Or perhaps:
|
So I've been even more confusing I guess! The order of jQuery and Popper.js doesn't matter: the sentence is meant to tell that both should come before our compiled JavaScript. So both of those will work fine:
|
It seems pretty clear to me that 'it' refers to 'our compiled JavaScript' and not 'jQuery,' especially with the example there. I suppose you could change 'before it' to 'first' to remove any possible ambiguity. |
The order only matters in what @ffoodd said #30873 (comment) The rest are common script inclusion principles. The order matters if the next script depends on another one, but that's not the case with jQuery and popper. We depend on jQuery and popper. This reminds me, we should redo all the getting started snippets to mention our bundle. That's what most people should use. |
Fixed in #30896 |
On the page https://getbootstrap.com/docs/4.5/getting-started/download/#bootstrapcdn it says:
It then shows an example of
See the issue? The example shows popper after jQuery, but the docs say it should come before it.
The error appears to exist in the description, and not the example. I suggest changing:
to:
The text was updated successfully, but these errors were encountered: