Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The text-hide() mixin has been deprecated as of v4.1.0. It will be removed entirely in v5. #26246

Closed
iPazooki opened this issue Apr 10, 2018 · 11 comments

Comments

@iPazooki
Copy link

Hi
After updating to Version 4.1.0. When I wanna compile my SCSS files I get this error:
The "text-hide()" mixin has been deprecated as of v4.1.0. It will be removed entirely in v5.
But when I comment .text-hide class in _text.scss every things go fine and there is no issue!

@mdo
Copy link
Member

mdo commented Apr 10, 2018

It shouldn't be an error, it should be a warning, which shouldn't affect compilation. The mixin was deprecated with v4.1 and was mentioned in our blog post.

@mdo mdo closed this as completed Apr 10, 2018
@casdevs
Copy link

casdevs commented Apr 21, 2018

ok, but shouldn't bootstrap itself not use @include text-hide() any longer then?
it's still included from line 57 of ./scss/utilities/_text.scss, so users get the deprecation warning even if they are not using text-hide() themselves anymore...

@RobertSmits
Copy link
Contributor

@casdevs True, but then the precompiled version wouldn't include .text-hide which can break sites using the precompiled bootstrap css or a cdn. And semantic versioning says you can only make breaking changes if you bump the major version.

@casdevs
Copy link

casdevs commented Apr 23, 2018

@RobertSmits ok, without further investigation I've assumed that internally, there is an alternative to the now deprecated text-hide mixin so bootstrap itself can set a good example of how to avoid using this deprecated feature. I've just wondered why compiling bootstrap without further modifications issues a warning now.

s-pace pushed a commit to algolia/docsearch-configs that referenced this issue Apr 24, 2018
@wlipa
Copy link

wlipa commented Apr 24, 2018

Having loud warnings about library internals is a bad smell. It makes it easy to ignore warnings, since there's nothing I'm doing to trigger them. Can there be some way to turn this off?

@wolfy1339
Copy link
Contributor

wolfy1339 commented Apr 25, 2018

This will be fixed in v4.1.1 (Fix committed to v4-dev). The warning will be silenced when importing Bootstrap, but not when the mixin is called directly in custom code
In the mean time, you can't do very much about it.

@wlipa
Copy link

wlipa commented Apr 25, 2018

Great, thanks! I see this now:

#26242

@vladanPro
Copy link

vladanPro commented Jun 15, 2018

I have same problem also in v4.1.1 ?
screen shot 2018-06-15 at 17 18 12
screen shot 2018-06-15 at 17 19 57

@wolfy1339
Copy link
Contributor

Can you confirm that you are using v4.1.1?
What does the actual text-hide() mixing look like?

@vladanPro
Copy link

I am sorry i use "bootstrap-material-design": "4.1.1" but not bootstrap. So i update and now i don't have problem. Thank you.

@suniLPATIDARr
Copy link

I am using core ui template of react and facing same issue none of given solution worked for me "@coreui/coreui": "^2.0.1",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants