Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class name of new range control #25742

Closed
ysds opened this issue Mar 1, 2018 · 4 comments
Closed

Class name of new range control #25742

ysds opened this issue Mar 1, 2018 · 4 comments

Comments

@ysds
Copy link
Contributor

ysds commented Mar 1, 2018

The new range control is defined with .custom-range class, but I wonder why it is CUSTOM.

The following is a list of bootstrap custom forms:

image

Why not .from-control-range or .form-range ?

Furthermore, I found .form-control-range class in the current SCSS:

// Make file inputs better match text inputs by forcing them to new lines.
.form-control-file,
.form-control-range {
display: block;
width: 100%;
}

but .form-control-range is not documented anywhere.
@mdo Any chance to treat the new range control as a standard or default rather than a custom, and change the class name to .from-control-range or .form-range?

Thanks.

@ysds
Copy link
Contributor Author

ysds commented Mar 1, 2018

Or we should documents about .form-control-range? e.g.

image

@wolfy1339
Copy link
Contributor

wolfy1339 commented Mar 1, 2018

I agree that it should be documented.
As for .custom-range, it's called "custom" because it looks the same across every browser. .form-control extends native styles

@mdo
Copy link
Member

mdo commented Mar 5, 2018

We should document .form-control-range for sure. I thought I did, but clearly missed it :).

@ysds
Copy link
Contributor Author

ysds commented Mar 5, 2018

My doubt was all clear now. Thanks.

Varunram added a commit to Varunram/bootstrap that referenced this issue Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants