Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css bug on homepage #2535

Closed
burningTyger opened this issue Mar 12, 2012 · 13 comments
Closed

css bug on homepage #2535

burningTyger opened this issue Mar 12, 2012 · 13 comments
Milestone

Comments

@burningTyger
Copy link
Contributor

as seen on http://twitter.github.com/bootstrap/base-css.html

@sushaantu
Copy link

Any more information you might add. Don't think I have seen this issue in any browser.

@burningTyger
Copy link
Contributor Author

I'm on current Chrome, Lion.

@Merg1255
Copy link

confirmed on firefox 11 and 13a1 and 12a2.

@JMayfield
Copy link

I'm on Lion 10.7.3 and Chrome 17.0.963.79 and I'm NOT seeing this bug.

EDIT: After a browser refresh, I'm seeing the bug as well.

@burningTyger
Copy link
Contributor Author

Have you all RELOADED your browser to see 2.0.2?

@JMayfield
Copy link

Oh, burningTyger's correct. I'm seeing the bug, post reload.

@burningTyger
Copy link
Contributor Author

seems to only affect <i> icon prepended forms.

@jubi4dition
Copy link

I got the same Problem :)
No matter if it's a icon. When i write it in the same line, there's no gap between prepend-input and input, but the prepend-input is still lower. I am not able to solve it :|

<div class="row">
<div class="span4">
<form accept-charset="utf-8">
<div class="input-prepend">
<span class="add-on"><i class="icon-envelope"></i></span><input type="text" class="input-large">
</div>
<div class="input-prepend">
<span class="add-on">P</span><input type="password" class="input-large"/>
</div>
<a href="#" class="btn btn-primary btn-large">
<i class="icon-home icon-white"></i> Login</a>
</form>
</div>
</div>

@robflaherty
Copy link

Appears to be caused by margin-bottom: 9px on the adjacent input. Removing margin or setting vertical-align: top on the .add-on class resolves it.*

*ish

Edit: Ah, the form is missing one of the form clases that sets the margin-bottom to 0 on input elements.

Edit #2: @jubi4dition: I'm seeing the same thing, that the whitespace is causing the horizontal gap.

@robflaherty
Copy link

Adding display: inline-block here introduced the whitespace problem.
91eef35#diff-4

Is it expected that everyone knows inline-block elements respect whitespace? If so the fix is a simple docs edit. Just read the heads-up in the changelog about .add-on elements. Submitted pull request.

robflaherty added a commit to robflaherty/bootstrap that referenced this issue Mar 13, 2012
@jubi4dition
Copy link

I don't really understand, when i use form-inline, then input-prepend and input fit together, but there's no vertical gap between the two input fields.

@robflaherty
Copy link

Regarding the vertical spacing problem, adding form-inline was a hack for the documentation. Prepended and appended inputs should be fixed to work in vertical forms. Looks like it can be achieved in a few ways:

  1. Set .add-on to vertical-align: top
  2. Set bottom margin to 0 on vertical form inputs

Seems like both might be problematic...

@mdo
Copy link
Member

mdo commented Mar 23, 2012

Resolved in 2.0.3-wip by removing the margin on inputs in the prepend/append components. Thanks!

@mdo mdo closed this as completed Mar 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants