Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<a> button :focus styles not overridden correctly. #21625

Closed
LarryAzevedo opened this issue Jan 9, 2017 · 1 comment
Closed

<a> button :focus styles not overridden correctly. #21625

LarryAzevedo opened this issue Jan 9, 2017 · 1 comment
Labels
confirmed css has-pr v4
Milestone
v4.0.0-beta

Comments

@LarryAzevedo
Copy link

On any desktop browser, do the following:

  1. Go to http://v4-alpha.getbootstrap.com/components/popovers/#dismiss-on-next-click
  2. Click on the red Dismissible popover button to bring up the popover.
  3. Finally, move your cursor off of the button.

The text of the button changes to blue; which in my opinion, looks and feels a little weird.
@pvdlg
Copy link
Contributor

pvdlg commented Jan 10, 2017

ref #21539

@bardiharborow bardiharborow changed the title Text Color Changes on Dismissible Popover <a> button :focus styles not overridden correctly. Jan 10, 2017
@pvdlg pvdlg mentioned this issue Jan 10, 2017
Closed
mdo added a commit that referenced this issue Jan 10, 2017
@mdo
fixes #21625, closes #21539
1314c79 
don't set focus styles on the anchor, just set hover styles
@mdo mdo mentioned this issue Jan 10, 2017
Merged
@mdo mdo added the has-pr label Jan 10, 2017
@mdo mdo added this to the v4.0.0-beta milestone Jan 10, 2017
mdo added a commit that referenced this issue Jan 16, 2017
@mdo
fixes #21625, closes #21539
fc82352 
don't set focus styles on the anchor, just set hover styles
@mdo mdo mentioned this issue Jan 16, 2017
Closed
@jasonkarns jasonkarns mentioned this issue Apr 3, 2017
Closed
This was referenced May 25, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed css has-pr v4
Projects
None yet
Milestone
v4.0.0-beta
Development

No branches or pull requests
4 participants
@mdo @bardiharborow @LarryAzevedo @pvdlg