Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom checkbox alignment possible regression #21023

Closed
sbaechler opened this issue Oct 27, 2016 · 0 comments
Closed

Custom checkbox alignment possible regression #21023

sbaechler opened this issue Oct 27, 2016 · 0 comments
Labels
css has-pr v4
Milestone
v4.0.0-alpha.6

Comments

@sbaechler
Copy link
Contributor

sbaechler commented Oct 27, 2016 •
edited
Loading

The checkbox alignment was changed in this commit: 82e7abc.

This broke the alignment on our page. I have not overridden the vertical alignment of the element.

Checkbox alignment

That magic number on line 64 looks a bit suspicious to me. Maybe the top margin needs to be calculated.

My $custom-control-indicator-size is 1.5em. Maybe the top value can be calculated from that value and the line height.
@mdo mdo added this to the v4.0.0-alpha.6 milestone Oct 27, 2016
mdo added a commit that referenced this issue Oct 27, 2016
@mdo
Calculcate the top offset for custom control indicators
2dcc50f 
Fixes #21023.

Uses some math functions to determine what the offset should be. This is helpful for those who customize the size of their indicators and still want them vertically centered.
@mdo mdo added the has-pr label Oct 27, 2016
@mdo mdo mentioned this issue Oct 27, 2016
Merged
@mdo mdo mentioned this issue Oct 28, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css has-pr v4
Projects
None yet
Milestone
v4.0.0-alpha.6
Development

No branches or pull requests
2 participants
@mdo @sbaechler