Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple accordions with different data-parent collapse each other #20923

Closed
martijn-basesoft opened this issue Oct 17, 2016 · 5 comments
Closed
Labels

Comments

@martijn-basesoft
Copy link

martijn-basesoft commented Oct 17, 2016

In bootstrap 4 alpha 4, wIth two different accordions on one page having different data-parent's, I would expect them to collapse indepdent of each other. However, the first accordion collapse panels in the second and visa versa.

See demo at http://codepen.io/anon/pen/JRaZyd

This example is based on the original documention at http://v4-alpha.getbootstrap.com/components/collapse/#accordion-example

@twbs-lmvtfy
Copy link

Hi @martijn-basesoft!

You appear to have posted a live example (http://codepen.io/anon/pen/JRaZyd.html), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

  • line 62, column 5 thru column 58: Duplicate ID headingOne.
  • line 75, column 5 thru column 58: Duplicate ID headingTwo.
  • line 88, column 5 thru column 60: Duplicate ID headingThree.
  • line 69, column 5 thru column 108: The aria-labelledby attribute must point to an element in the same document.
  • line 82, column 5 thru column 105: The aria-labelledby attribute must point to an element in the same document.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!

(Please note that this is a fully automated comment.)

@martijn-basesoft
Copy link
Author

Updated demo: http://codepen.io/anon/pen/JRaZyd

@mdo
Copy link
Member

mdo commented Oct 18, 2016

Can you try with the latest from v4-dev? We merged some changes recently to the collapse plugin.

@Johann-S
Copy link
Member

Johann-S commented Oct 18, 2016

Duplicate : #18824

and they are a PR to fix that : #18847

@mdo
Copy link
Member

mdo commented Oct 18, 2016

Closing as duplicate then! Thanks @Johann-S.

@mdo mdo closed this as completed Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants