Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple accordions collapse bug #18824

Closed
leymannx opened this issue Jan 9, 2016 · 1 comment
Closed

multiple accordions collapse bug #18824

leymannx opened this issue Jan 9, 2016 · 1 comment
Labels
confirmed js v4

Comments

@leymannx
Copy link

leymannx commented Jan 9, 2016

Added two accordions both with all unique IDs. Page load fine. Each with one panel open. Now clicking a panel on one accordion to open leads to other accordion's panel to close. See example here: https://jsfiddle.net/leymannx/9x92umfk/
@cvrebert cvrebert changed the title V4 multiple accordions collapse bug multiple accordions collapse bug Jan 10, 2016
@cvrebert
Copy link
Collaborator

bootstrap/js/src/collapse.js

Line 124 in 64b9ad4

actives = $.makeArray($(Selector.ACTIVES))
is grabbing all active panels in the document instead of limiting itself to active panels within the parent/accordion.

@Johann-S Johann-S mentioned this issue Jan 11, 2016
Merged
@Johann-S Johann-S mentioned this issue Feb 24, 2016
Closed
This was referenced Apr 26, 2016
Closed
Closed
@RyanZim RyanZim mentioned this issue May 9, 2016
Closed
@Johann-S Johann-S mentioned this issue Oct 18, 2016
Closed
@mdo mdo mentioned this issue Oct 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed js v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cvrebert @leymannx