Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs are contradictory as to which classes should be used and when and how (in what combinations, etc) for stacked and inlined checkboxes/radios markup #20578

Closed
notmessenger opened this issue Aug 25, 2016 · 1 comment

Comments

@notmessenger
Copy link

I asked this question in #20403 (comment) but am making it its own issue for more visibility.

The chart at the bottom of the http://v4-alpha.getbootstrap.com/components/forms/#form-controls section lists these classes as being applicable to radio and checkbox controls:

  • .radio
  • .radio-inline
  • .checkbox
  • .checkbox-inline

The only such example though I see of these classes being used is in this code example within the same section:

  <div class="checkbox">
    <label>
      <input type="checkbox"> Check me out
    </label>
  </div>

The use of these classes seems to be contradicted (maybe?) in http://v4-alpha.getbootstrap.com/components/forms/#inline which uses a different set of classes for the inline or non-inline display of these controls.

Which classes should be used and when and how (in what combinations, etc)?

@notmessenger notmessenger changed the title Which classes should be used and when and how (in what combinations, etc) for stacked and inlined checkboxes/radios markup Documentation is contradictory as to which classes should be used and when and how (in what combinations, etc) for stacked and inlined checkboxes/radios markup Aug 29, 2016
@notmessenger notmessenger changed the title Documentation is contradictory as to which classes should be used and when and how (in what combinations, etc) for stacked and inlined checkboxes/radios markup v4 documentation is contradictory as to which classes should be used and when and how (in what combinations, etc) for stacked and inlined checkboxes/radios markup Aug 29, 2016
@cvrebert cvrebert changed the title v4 documentation is contradictory as to which classes should be used and when and how (in what combinations, etc) for stacked and inlined checkboxes/radios markup Docs are contradictory as to which classes should be used and when and how (in what combinations, etc) for stacked and inlined checkboxes/radios markup Sep 1, 2016
mdo added a commit that referenced this issue Sep 5, 2016
- Update docs examples to use newer .form-check suite of classes
Update form validation mixin to use newer classes as well
@mdo mdo added this to the v4.0.0-alpha.4 milestone Sep 5, 2016
twbs-savage pushed a commit to twbs-savage/bootstrap that referenced this issue Sep 5, 2016
…twbs#20629)

- Update docs examples to use newer .form-check suite of classes
- Update form validation mixin to use newer classes as well
@mdo
Copy link
Member

mdo commented Sep 5, 2016

Fixed by #20629.

@mdo mdo closed this as completed Sep 5, 2016
krissihall pushed a commit to krissihall/bootstrap that referenced this issue Sep 7, 2016
…0_aeo-bootstrap

* 'v4-dev' of https://github.com/twbs/bootstrap: (860 commits)
  Update Bower url (HTTP to HTTPS) (twbs#20658)
  Add Edge entry for twbs#20507 to Wall of Browser Bugs
  Move Sauce credentials out of .travis.yml
  new hashes
  grunt
  versions
  grunt
  Fixes twbs#20608 and twbs#20578: Consistent checkbox and radio markup (twbs#20629)
  Disable important flag on Sass linter (twbs#20627)
  Fixes twbs#20619: Add important to the hover/focus as well (twbs#20626)
  grunt
  Fix segmented buttons in input group docs (twbs#20489)
  Renamed contextual classes for tables (twbs#20505)
  Make .card class inside .card-columns display: block too (twbs#20447)
  grunt
  Remove unused $variables in grid mixins (twbs#20597)
  fixes twbs#20485: use rem units in alert dismiss (twbs#20625)
  Fix README badge alignment.
  Update ads code and styles (also fixes twbs#20477 in different way)
  Fixes twbs#20504: Mention .divider to .dropdown-divider name change
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants