-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An <hx class=".panel-title"> should inherit color from .panel-heading #11544
Comments
Looks fine for me, I can't reproduce an issue. |
@maniqui : thanks! I could reproduce this because I'm defining a color for
instead of inherit which is the default. If inherit is used, then it works fine, if you define a color, then the panel titles are the @headings-color not the @panel-primary-text, etc color. also, if you change the order in type.less to put the emphasis classes after the h1, .h1 - h6, .h6 then h1.text-primary and so on will be the colors you want and also not the @headings-color |
Cool! |
…e proper text color when customizing @headings-color
…e proper text color when customizing @headings-color
The class
.panel-title
, which is usually applied to a heading element (<hx class="panel-title">
) doesn't inherit the color defined for.panel-heading
, which is defined in this rule:Instead, it currently inherits its color from the one defined in the rule
h1, h2, h3..., .h1, .h2, .h3... {}
.My opinion is that the
.panel-title
class should inherit its color from.panel-heading
class.The change is simple. In
panels.less
, do:Sorry for not submitting a proper patch or a pull request. I'm a bit short of time right now.
The text was updated successfully, but these errors were encountered: