Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic template points to files that don't exist #10989

Closed
michelle0225 opened this issue Oct 8, 2013 · 4 comments · Fixed by #11013
Closed

Basic template points to files that don't exist #10989

michelle0225 opened this issue Oct 8, 2013 · 4 comments · Fixed by #11013
Labels
confirmed docs examples js
Milestone
v3.0.1

Comments

@michelle0225
Copy link

The basic template HTML that is provided in the documentation references a directory and files that are not included in the compiled Bootstrap download. http://getbootstrap.com/getting-started/#template

<!--[if lt IE 9]>
    <script src="../../assets/js/html5shiv.js"></script>
    <script src="../../assets/js/respond.min.js"></script>
    <![endif]-->

screen shot 2013-10-08 at 5 22 20 pm

screen shot 2013-10-08 at 5 20 48 pm
@cvrebert
Copy link
Collaborator

cvrebert commented Oct 8, 2013

I suggest that we switch the html5shiv to a CDN URL like for jQuery. Other than where strictly necessary in the examples, I don't think we should explicitly refer to stuff in /docs-assets/ in the documentation prose itself.

This was referenced Oct 8, 2013
Closed
Closed
@cvrebert
Copy link
Collaborator

cvrebert commented Oct 9, 2013

Deferring respond.js problem to #11003.

cvrebert added a commit that referenced this issue Oct 9, 2013
@cvrebert
use CDN for html5shiv instead of vendoring it; fixes part of #10989
d72768a
cvrebert added a commit that referenced this issue Oct 9, 2013
@cvrebert
use CDN for jQuery instead of vendoring it; fixes part of #10989
5e65233
@cvrebert cvrebert mentioned this issue Oct 9, 2013
Merged
@coliff
Copy link
Contributor

coliff commented Oct 16, 2013

@cvrebert can we update the html5shiv to latest version 3.7.0? (https://github.com/aFarkas/html5shiv)

@cvrebert
Copy link
Collaborator

@coliff Done: cf95fe2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed docs examples js
Projects
None yet
Milestone
v3.0.1
Development

Successfully merging a pull request may close this issue.

Use CDNs for more example JavaScripts twbs/bootstrap
3 participants
@cvrebert @coliff @michelle0225