Duplicate property definitions

[ujovlado]

Hi, I found two duplicate property set in exported CSS.
I don't know if it's the purpose or there's problem with LESS to CSS conversion.

/* line 3483, padding */

.btn-group-xs > .btn {
  padding: 5px 10px;
  padding: 1px 5px;
  font-size: 12px;
  line-height: 1.5;
  border-radius: 3px;
}


/* line 4956, display */

.thumbnail {
  display: inline-block;
  display: block;
  height: auto;
  max-width: 100%;
  padding: 4px;
  line-height: 1.428571429;
  background-color: #ffffff;
  border: 1px solid #dddddd;
  border-radius: 4px;
  -webkit-transition: all 0.2s ease-in-out;
          transition: all 0.2s ease-in-out;
}

Thx

[cvrebert]

Confirmed that this is still present in latest master.

[cvrebert]

The .btn-group-xs problem ends up being due to less/buttons.less:

.btn-sm,
.btn-xs {
  /* line-height: ensure proper height of button next to small input */
  .button-size(@padding-small-vertical; @padding-small-horizontal; @font-size-small; @line-height-small; @border-radius-small);
}
.btn-xs {
  padding: 1px 5px; /* PROBLEM!: .button-size ABOVE ALSO SETS padding*/
}

We should probably separate the .btn-xs and .btn-sm declarations and have .btn-xs use its own .button-size invocation. And we might wanna add vars for the 1px & 5px padding amounts, instead of hardcoding them.

[cvrebert]

Short of some LESS trick, I don't know if the .thumbnail problem is avoidable:

/* less/thumbnails.less */
.thumbnail {
  .img-thumbnail();
  display: block; // Override the inline-block from `.img-thumbnail`