-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation states not working on radio, checkbox, form-control-static #10522
Comments
|
|
IMO it's right. You just have to mark your label with <label class="radio control-label">
<input type="radio"> Italian
</label> |
@cvrebert I think What you think? |
…ne, and .checkbox-inline twbs/bootstrap#10522
…o, .checkbox, .radio-inline, and .checkbox-inline
@mdo fix does not change the input radio/checkbox itself. All other form elements change their border color when has-* is present except input radio/checkbox: To fix this, CSS outline should be used since input radio/checkbox don't have a border: .has-error input[type="radio"] {
outline: 1px solid @state-danger-text;
} It does not look great inside the browser (Chrome 34 Win7) but at least it is coherent with the other form inputs. |
We won't be styling the radio and checkbox inputs. |
"We won't be styling the radio and checkbox inputs." - Yet another bad practice for usability and accessibility. @tkrotoff Fantastic solution! We've found having the border around individual checkboxes in a group becomes rather cumbersome. Instead, we wrap a field set or div (whichever is most semantically applicable) around them and add our red border to that. Cheers! |
…o, .checkbox, .radio-inline, and .checkbox-inline
Validatio states should work the same for radio and checkboxes as well. If applied .has-error class on .form-group containing radio and/or checkboxes should apply styles on them as well. It is not happening right now.
The text was updated successfully, but these errors were encountered: