Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with .table-bordered in a .panel #10492

Closed
jcberquist opened this issue Sep 6, 2013 · 5 comments · Fixed by #11970
Closed

Issues with .table-bordered in a .panel #10492

jcberquist opened this issue Sep 6, 2013 · 5 comments · Fixed by #11970
Labels
Milestone

Comments

@jcberquist
Copy link

The new styles for using bordered tables in panels (without double bordering) are great! But I do have a couple of minor issues/enhancement requests. I would like to be able to wrap a bordered table in a panel with .table-responsive for scrolling purposes. Since the recently added css selectors use .panel>.table-bordered, the new styles won't apply in such a case. Also, if the table uses the .table-striped class and the last row is odd, then the table cell backgrounds clip over the panel border in the bottom corners.

@ghost
Copy link

ghost commented Sep 10, 2013

Confirmed: http://jsfiddle.net/DNFfV/

@mdo mdo closed this as completed in 28e5572 Sep 12, 2013
@supergibbs
Copy link
Contributor

The .table-striped in a .panel is still an issue.

The issue is actually if a td is given a background (instead of transparent) it clips the rounded corners of the panel.

@mdo
Copy link
Member

mdo commented Dec 16, 2013

@supergibbs Only problem I saw was the rounded corners, which I just fixed for v3.1.

@supergibbs
Copy link
Contributor

@mdo Yes I that is the issue, I was just pointing out if the td background-color was set from any styling the issue occurred. It wasn't necessarily the .table-striped class.

Slight bug in your commit, panels.less:106 should be border-bottom-right-radius: (@panel-border-radius - 1); (not left)

There is still the rare use case when the panel has no heading or body and is just used to add a colored rounded border. The table clips the top corners (if the first row has a background color). Not sure if this is supported though.

http://jsfiddle.net/DNFfV/10/

@supergibbs
Copy link
Contributor

Updated examples with my pull request

http://jsfiddle.net/DNFfV/16/

mdo added a commit that referenced this issue Dec 23, 2013
supergibbs added a commit to supergibbs/bootstrap that referenced this issue Dec 24, 2013
- Made more generic. Applies to "> .table" and "> .table-responsive > .table" to support td/tr background colors too and not just .table-striped
- Supports tfoot
mdo added a commit that referenced this issue Dec 24, 2013
stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
…able" and "> .table-responsive > .table" to support td/tr background colors too and not just .table-striped - Supports tfoot
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
- Made more generic. Applies to "> .table" and "> .table-responsive > .table" to support td/tr background colors too and not just .table-striped
- Supports tfoot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants