Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contextual table row styles shouldn't override border-color #10341

Closed
hereswhatidid opened this issue Sep 1, 2013 · 7 comments
Closed

contextual table row styles shouldn't override border-color #10341

hereswhatidid opened this issue Sep 1, 2013 · 7 comments

Comments

@hereswhatidid
Copy link

[WAS: table-bordered class conflicts with setting individual row styles]
When a table is set to "table-bordered" the lower table cell border is lost when you apply a contextual class to a row or cell.

@hereswhatidid
Copy link
Author

@mdo
Copy link
Member

mdo commented Sep 6, 2013

I see no lose of border—the contextual classes set their own border. http://jsbin.com/aFuGEVe/3/edit

@mdo mdo closed this as completed Sep 6, 2013
@hereswhatidid
Copy link
Author

You don't see the different border styles between the two tables? I can verify on Chrome and FireFox the bottom borders occurring below the first row shifts when you use bordered vs non-bordered table styles.

@cvrebert
Copy link
Collaborator

cvrebert commented Sep 6, 2013

@hereswhatidid I think they're there, but just a different color?

@hereswhatidid
Copy link
Author

They are different colors, that's my point. I think there's possibly just not a style specifically declared for the bordered table when a contextual class is applied to it, but there is for the non-bordered. IMHO, I think the style used in the non-bordered is what the bordered should look like as well.

@cvrebert
Copy link
Collaborator

cvrebert commented Sep 7, 2013

@hereswhatidid It would have been good to have clarified that then.

@cvrebert cvrebert reopened this Sep 7, 2013
@mdo mdo closed this as completed in c6e76d9 Oct 29, 2013
@hereswhatidid
Copy link
Author

Great, thanks!

stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants