Skip to content

Commit

Permalink
Remove color property from badge class
Browse files Browse the repository at this point in the history
I suggest removing `color: #FFF` from the `badge` class, because it is
provided by the `badge-<modifier>` classes along with a
background-color, whereas there is no corresponding background-color
provided on the `badge` class itself.

Background
----------

According to the documentation:

> [badge] Requires one of the contextual, color modifier classes for `color` and
> `background-color`.

That is, color and background color should be provided by a modifier
class, rather than the badge class itself.

e.g. `<span class='badge badge-primary'>4</span>`

In general, providing a `color` property without also providing a
`background-color` should be avoided. [W3 QA tips]

In this context, this is a problem only if someone creates a `badge`
without providing a modifier. Such an omition may be difficult to trouble-shoot,
because this will most likely yield white text on a white background.

[W3 QA tips](https://www.w3.org/QA/Tips/color)
  • Loading branch information
Jon Wolski committed Aug 18, 2017
1 parent 74d9639 commit f07d870
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion scss/_badge.scss
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
font-size: $badge-font-size;
font-weight: $badge-font-weight;
line-height: 1;
color: $badge-color;
text-align: center;
white-space: nowrap;
vertical-align: baseline;
Expand Down

0 comments on commit f07d870

Please sign in to comment.