Skip to content

Commit

Permalink
fix focus shadows, if enabled
Browse files Browse the repository at this point in the history
  • Loading branch information
@mdo
mdo committed Oct 9, 2016
1 parent 3fa312c commit b77b874
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions scss/mixins/_forms.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@
.custom-control {
color: $color;
}

// Set the border and box shadow on specific inputs to match
.form-control {
border-color: $color;
// @include box-shadow(inset 0 1px 1px rgba(0,0,0,.075)); // Redeclare so transitions work

&:focus {
// border-color: darken($border-color, 10%);
// $shadow: inset 0 1px 1px rgba(0,0,0,.075), 0 0 6px lighten($border-color, 20%);
// @include box-shadow($shadow);
@if $enable-rounded {
&:focus {
box-shadow: $input-box-shadow, 0 0 6px lighten($color, 20%)
}
}
}

Expand Down

4 comments on commit b77b874

@validide
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be '@if $enable-shadows' instead of '@if $enable-rounded' on line 20

@validide
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavisMiculis I know about those options. I was wondering if the current condition is a bug or 'by design'?

@mdo
Copy link
Member Author

@mdo mdo commented on b77b874 Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah that looks wrong. If it's still that in v4-dev, can you open an issue? <3

@pvdlg
Copy link
Contributor

@pvdlg pvdlg commented on b77b874 Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still in v4-dev. I created the PR #20964

Please sign in to comment.