Skip to content

Commit

Permalink
Remove vendor prefixes from appearance: none.
Browse files Browse the repository at this point in the history
  • Loading branch information
bardiharborow committed Feb 21, 2017
1 parent 371bf95 commit 9bacc67
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions scss/_custom-forms.scss
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,7 @@
background-size: $custom-select-bg-size;
border: $custom-select-border-width solid $custom-select-border-color;
@include border-radius($custom-select-border-radius);
// Use vendor prefixes as `appearance` isn't part of the CSS spec.
-moz-appearance: none;
-webkit-appearance: none;
appearance: none;

&:focus {
border-color: $custom-select-focus-border-color;
Expand Down

3 comments on commit 9bacc67

@fran-worley
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has this been stripped out already? I'm testing this on Chrome 60.0.3112.90 (mac Os 10.12.6) and the appearance attribute isn't recognised. I've now got double select icons.

@mdo
Copy link
Member

@mdo mdo commented on 9bacc67 Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autoprefixer adds this for us automatically during compilation.

@fran-worley
Copy link

@fran-worley fran-worley commented on 9bacc67 Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, cool, odd that I've not got them coming through at all since upgrading to beta. Comes through fine on alpha6 and your docs site. I've not changed my inclusion code at all since upgrading.

I've doubled checked the scss coming through from NPM doesn't have vendor prefixes (or at least not on my custom selects). So in beta we autoprefix ourselves. No problem missed that bit of the docs since upgrading! Thanks for the quick reply

Please sign in to comment.