Skip to content

Commit

Permalink
Fix incorrect select height calculation (#21171)
Browse files Browse the repository at this point in the history
  • Loading branch information
schliflo authored and mdo committed Nov 28, 2016
1 parent bccbc4f commit 959c4e5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion scss/_forms.scss
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
select.form-control {
&:not([size]):not([multiple]) {
$select-border-width: ($border-width * 2);
height: calc(#{$input-height} - #{$select-border-width});
height: calc(#{$input-height} + #{$select-border-width});
}

&:focus::-ms-value {
Expand Down
2 changes: 1 addition & 1 deletion scss/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ $input-padding-y-sm: .25rem !default;
$input-padding-x-lg: 1.5rem !default;
$input-padding-y-lg: .75rem !default;

$input-height: (($font-size-base * $line-height-base) + ($input-padding-y * 2)) !default;
$input-height: (($font-size-base * $input-line-height) + ($input-padding-y * 2)) !default;
$input-height-lg: (($font-size-lg * $line-height-lg) + ($input-padding-y-lg * 2)) !default;
$input-height-sm: (($font-size-sm * $line-height-sm) + ($input-padding-y-sm * 2)) !default;

Expand Down

0 comments on commit 959c4e5

Please sign in to comment.