Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace sass with sassc #1156

Closed
dennisvandehoef opened this issue Apr 3, 2018 · 4 comments
Closed

replace sass with sassc #1156

dennisvandehoef opened this issue Apr 3, 2018 · 4 comments

Comments

@dennisvandehoef
Copy link

Replace the usage of the sass gem with the sassc gem, as suggested in the end-of-life blog post: http://sass.logdown.com/posts/7081811

According to this benchmark, it also might speed up the sass compilation time as an extra win: https://marianposaceanu.com/articles/making-rails-asset-pipeline-faster

@michaelhiiva
Copy link

michaelhiiva commented Apr 5, 2018

Yes, the sass gem should be replaced because it will soon be outdated and the sassc gem is recommended for Ruby installs. But making this change would require quite a few changes in the documentation, code and tests. I would like try and address this in a pull request if the sassc gem change is agreed upon.

Also, the change is noted on Ruby Sass that it will be depreciated in one year after the release of Dart Sass and users of the sass gem need to migrate. In addition, to the sassc gem being recommended.

If you use the sass gem as a library, the sassc gem is the most seamless way to move away from Ruby Sass. It uses LibSass to provide the same API for compiling Sass and defining custom functions as Ruby Sass, except that it uses the SassC module instead of Sass. However, it doesn't yet support the same Importer API. You can also use the sassc-rails gem to plug smoothly into Ruby on Rails.

@mokolabs
Copy link

FWIW, I don't think adding sassc support will be that difficult -- at least on the 2.X branch.

My app is stuck on Bootstrap 2.3, but I wanted sassc support... so I cloned the current gem, rolled back to the original 2.3 release commit (since there is no tracking branch for 2.3), and then added sassc.

You can see it here:
https://github.com/mokolabs/bootstrap-sass-2.3-with-sassc-rails

@mileslane
Copy link

What is the status of this?

glebm added a commit that referenced this issue Aug 21, 2018
@glebm glebm closed this as completed Aug 21, 2018
@mokolabs
Copy link

Sweet. Thanks, @glebm!

glebm added a commit that referenced this issue Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants