Allow prototype enhancements. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AVA currently creates an enhanced assertion object each time. This is costly. This allows prototype enhancement by adding a `bindReceiver` option. `bindReceiver` defaults to `true`, meaning assertion methods have their `this` value bound to the original assertion. Setting `bindReceiver` to false causes the `this` reference to be passed through from the actual invocation.
Closed
|
@jamestalmage Thanks for the improvement
Sure 👍 |
|
Confirmed. See avajs/ava#461 It wasn't the biggest problem, but it did improve that benchmark suite from 5 seconds to 4 seconds. Merge at will! 😄 Let me know when it's released so I can update that AVA PR. |
|
LGTM. Prototype enhancement is long-sought feature of empower! |
|
@twada - one more potential enhancement coming |
|
@jamestalmage Oh wow Please feel free to update this branch or making another one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVA currently creates an enhanced assertion object each time. This is costly. This allows prototype enhancement by adding a
bindReceiveroption.Setting
bindReceivertotrue(the default), assertion methods have theirthisvalue bound to the original assertion object.Setting
bindReceiverto false causes thethisreference to captured at the actual time of invocation. This allows the enhancement of prototypes.@twada - Hold off on merging until I confirm performance improvements.
Reference:
avajs/ava#460