Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QR code generating without white background #117

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Cormac131
Copy link

@Cormac131 Cormac131 commented Feb 5, 2024

Description

Fix QR code generating without a white background. Changed to PNG as when testing HA theme was overwriting the SVG elements background colour.

  • Change QR code generation to PNG
  • Import pypng as a dependency

After changes:

Light:
image

Dark:
image

Fixes # 112

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Local Testing

Diagnostic File

None needed, visual bug

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Cormac131
Copy link
Author

@shihuimiao @zlinoliver can you take a look at this PR?

@Sir-Udo
Copy link

Sir-Udo commented Jul 22, 2024

Hi,
for a few weeks now, every time I restart HA, I've been asked to re-authenticate myself in Smartlife. Can this be fixed?
I heard it was similar at TUYA, they probably fixed it at Tuya. Thanks Udo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants