mctp: Fix check for dev_hard_header() result

BugLink: https://bugs.launchpad.net/bugs/1969107 [ Upstream commit 60be976 ] dev_hard_header() returns the length of the header, so we need to test for negative errors rather than non-zero. Fixes: 889b7da ("mctp: Add initial routing framework") Signed-off-by: Matt Johnston <[email protected]> Signed-off-by: David S. Miller <[email protected]> Signed-off-by: Sasha Levin <[email protected]> (cherry picked from commit 71d28e5073b817189418ddd694e35e08d1c79cf3) Signed-off-by: Paolo Pisati <[email protected]>
tuxedocomputers · May 20, 2022 · 54aa036 · 54aa036
1 parent c2a56e1
commit 54aa036
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/net/mctp/route.c b/net/mctp/route.c
@@ -396,7 +396,7 @@ static int mctp_route_output(struct mctp_route *route, struct sk_buff *skb)
 
 	rc = dev_hard_header(skb, skb->dev, ntohs(skb->protocol),
 			     daddr, skb->dev->dev_addr, skb->len);
-	if (rc) {
+	if (rc < 0) {
 		kfree_skb(skb);
 		return -EHOSTUNREACH;
 	}