Skip to content

Commit

Permalink
gracefully acknowledge previously added affiliate links
Browse files Browse the repository at this point in the history
  • Loading branch information
Iulius Gutberlet committed Feb 28, 2013
1 parent 1c802d9 commit 9f778fc
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion chrome/content/geturl.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@
for (var config in configurations) {
if (configurations.hasOwnProperty(config)) {
if (url.match(configurations[config].rx)) {
if (url.indexOf("tag=") === -1) {
//gracefully acknowledge existing affiliate tags
if (url.indexOf(config.params[0].param) === -1) {
win = aWebProgress.DOMWindow;
win.document.location.replace(url + (url.indexOf("?") >= 0 ? "&" : "?") + createTag(config.params));
break;
Expand Down

2 comments on commit 9f778fc

@rikai
Copy link

@rikai rikai commented on 9f778fc Mar 17, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mirroring the post from the chrome extension:

Mmm, this is the main bit of the commit i have issue with. If someone has installed the JB extension it's assumed they want the JB affiliate tags applied at all relevant sites without having to check to verify at each site that the tag is being applied.

Having to do that defeats half the point of the extension. What i would prefer to here is to add an icon to the bar for JB, and allow people to disable the extension functionality to allow people to use other affiliate codes if they need to. This would be similar to how Adblock Plus allows you to enable/disable functionality on a temporary basis if you've used that before?

I've had JupiterBroadcasting#1 open and have opened JupiterBroadcasting/JBAR-Chrome#10 to track this for chrome to match.

@tuxbox
Copy link
Owner

@tuxbox tuxbox commented on 9f778fc Apr 1, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I'm glad to get a response from you. My point is simply that I assume the audience of JB to be very tech savy, hence if they click on a ad link on a different website, they are aware and potentially choosing to support that particular site with their purchase. As default they support JB but in that particular case they might be choosing not to. I just think that this is a less aggressive option.
Maybe I am off on that anyways and there's no need for a solution to this and you can save the effort ;)

Please sign in to comment.