Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode #79

Closed
geekyahmed opened this issue Jun 11, 2020 · 2 comments
Closed

Add dark mode #79

geekyahmed opened this issue Jun 11, 2020 · 2 comments
Labels
p4 Low priority tasks

Comments

@geekyahmed
Copy link

Is your feature request related to a problem? Please describe.
This is actually a great way to hell users have a much better experience using dark mode especially for people who don't like the exposure of light.

Describe the solution you'd like
Since it is based on Nexjsand react, a couple of components are out there that you can be able to integrate to make it seamless and easy to use.

Describe alternatives you've considered
None actually

@nicholaschiang nicholaschiang changed the title add dark and light mode toggle for users Add dark mode Jun 11, 2020
@nicholaschiang
Copy link
Member

Thanks @geekyahmed (PRs are always welcome too, if you want to have a stab at implementing this yourself)!

We'll have to change our config.$colors Sass variable (defined in src/styles/config.scss) to be global CSS variables that are toggled by the dark/light mode toggle @geekyahmed was referring to (this is what Vercel's website does right now).

We'll want to follow the Material Design spec for dark theming as well (e.g. the Vercel dark theme has too much contrast IMO).

@nicholaschiang nicholaschiang removed their assignment Jun 11, 2020
@geekyahmed
Copy link
Author

Sure I will

nicholaschiang added a commit that referenced this issue Nov 18, 2020
Fixes #79 (though there is still some theming work to do).
nicholaschiang added a commit that referenced this issue Nov 18, 2020
Fixes #79 (though there is still some theming work to do).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4 Low priority tasks
Projects
None yet
Development

No branches or pull requests

2 participants