-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(input): clearable bug while use chinese input #979
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tusimple/naive-ui/CBNP5JqFnR8vepitdcmystevyDTN |
Codecov Report
@@ Coverage Diff @@
## main #979 +/- ##
==========================================
- Coverage 47.12% 47.11% -0.01%
==========================================
Files 511 511
Lines 12593 12594 +1
Branches 3548 3549 +1
==========================================
Hits 5934 5934
- Misses 5632 5633 +1
Partials 1027 1027
Continue to review full report at Codecov.
|
@Volankey 这和之前的 form item 的一个 bug 有关,关联一下看看对不对 |
合一下pr @07akioni |
hoverRef.value = false | ||
// FIX: https://github.com/TuSimple/naive-ui/issues/905 | ||
if (!isComposingRef.value) { | ||
hoverRef.value = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我发现这个 hoverRef.value 会影响 showClearButton,这不是正确的改法,想要避免 rerender 需要 useMemo
Fix #905
我也不知道为啥在 clearable 情况下,mouseleave事件会触发compositionEnd,只知道是这个问题